Makefile refactors for global install and new sysroot #801
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Docker Images PR (which should work after this): #785 |
dwightguth
approved these changes
May 26, 2020
There was a problem hiding this comment.
This looks good. I had one minor suggestion, but it looks like that variable isn't really used anywhere, so I'm going to approve.
One other thing to note: You don't need to add -I include/kllvm if you add kllvm/ before your includes to the runtime directory. So it would be kllvm/runtime/header.h. It's up to you though, you're free to keep the code with the change you just made as well.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR makes several changes in preparation for (i) updating the K submodule to the new sysroot, and (ii) using K Docker Images for CI (with a global K install).
Makefileandkevm. In order of priority, first it's (i) what the user sets environment variable to, (ii) the submodule if the submodule is present, and (iii) a global install of K found withwhich kompile.git submodule update ...are removed from theMakefile, because the Makefile should not depend on the VCS that is used to store it. This also makes it easier to have a custom commit of K in the submodule without having to commit it (for example).LINK_PROCPSis removed, in favor of aSTANDALONE_KOMPILE_OPTSflag which holds all the kompile options for the standalone build (and adds-lprocpsfor Linux systems).cmake/clientfile is updated to include the paths needed for a global install of K.