Skip to content

Commit

Permalink
Use gnu tar format for the bug reports (#4548)
Browse files Browse the repository at this point in the history
This change enforces the GNU format of tar files instead of the default
POSIX.1-2001 pax format. This is necessary because:
- the filenames in the bug reports are often longer than the
format-portable restriction of 256 characters
- the Haskell
[library](https://hackage.haskell.org/package/tar-0.6.3.0/changelog) we
use to work with tar does not support the pax format. However, it does
support the GNU format which also allows long names.
  • Loading branch information
geo2a authored Jul 24, 2024
1 parent 353900c commit ae6d419
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion pyk/src/pyk/utils.py
Original file line number Diff line number Diff line change
Expand Up @@ -681,7 +681,7 @@ def __init__(self, bug_report: Path) -> None:
def add_file(self, finput: Path, arcname: Path) -> None:
if str(finput) not in self._file_remap:
self._file_remap[str(finput)] = str(arcname)
with tarfile.open(self._bug_report, 'a') as tar:
with tarfile.open(self._bug_report, 'a', format=tarfile.GNU_FORMAT) as tar:
tar.add(finput, arcname=arcname)
_LOGGER.info(f'Added file to bug report {self._bug_report}:{arcname}: {finput}')

Expand Down

0 comments on commit ae6d419

Please sign in to comment.