Fix quoting in IDs #2968
Merged
Fix quoting in IDs #2968
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
radumereuta
approved these changes
Oct 10, 2022
dwightguth
requested changes
Oct 10, 2022
dwightguth
approved these changes
Oct 10, 2022
|
I approved but you might want to add a test for a non Id sort to the test suite also. |
This was referenced Oct 17, 2022
radumereuta
pushed a commit
that referenced
this pull request
Nov 10, 2022
…2431) * haskell-backend/src/main/native/haskell-backend: 272a2e528 - Update dependency: deps/k_release (#2968) * haskell-backend/src/main/native/haskell-backend: 2e5140267 - Update dependency: deps/k_release (#2970) * haskell-backend/src/main/native/haskell-backend: 51edc9821 - Move Kore.Simplify.Rule (#2979)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The problem here is that the re-wrapping of constant-folded values (i.e. after calling the compile-time Java implementation of the hook) into their argument positions will enquote a string result, even if it's of sort
Id. ForIdresults, we want to just construct the token directly..Fixes #2315