Don't trim list separators #4596
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tothtamas28
approved these changes
Aug 20, 2024
|
For now, let's add a warning that is printed if you have a separator that is only whitespace. I guess that check can be implemented manually, just check against regex |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #4592
Previously, we trimmed list separators, presumably under the assumption that
#Layoutdeletes all whitespace and the user may end up including redundant whitespace. This is hacky and a faulty assumption given that we allow custom#Layout.For now, we just remove the
trim()call. This shouldn't cause issues downstream - I've manually checked that allList{...}andNeList{...}declarations in the EVM, C, and WASM semantics are already correct. If anything was missed, it's an easy fix.A proper solution is described in #4595