Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove orphan BYTES sort #302

Merged
merged 2 commits into from
Jul 9, 2024
Merged

Remove orphan BYTES sort #302

merged 2 commits into from
Jul 9, 2024

Conversation

Baltoli
Copy link
Contributor

@Baltoli Baltoli commented Jul 9, 2024

This PR removes a spurious declaration of an all-caps BYTES sort. This sort has no inhabiting terms, and so hasn't interfered with anything up until now. However, because of the case-sensitivity issue in runtimeverification/k#4508, the Kasmer-MX project ends up getting isBytes(_) rewriting to false unconditionally because isBYTES(_) is always false: #301

@Baltoli
Copy link
Contributor Author

Baltoli commented Jul 9, 2024

I tested the kasmer-multiversx reproduction of the original bug against this branch, and the failure no longer happens, so I'm confident this is the proper solution!

@Baltoli Baltoli requested a review from jberthold July 9, 2024 17:15
@rv-jenkins rv-jenkins merged commit eb4e1b2 into master Jul 9, 2024
6 checks passed
@rv-jenkins rv-jenkins deleted the case-insensitive branch July 9, 2024 20:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants