Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Build error: no viable overloaded '+=' (macOS 14.4.1) #284

Closed
anazarovflohealth opened this issue Apr 18, 2024 · 2 comments · Fixed by #300
Closed

Build error: no viable overloaded '+=' (macOS 14.4.1) #284

anazarovflohealth opened this issue Apr 18, 2024 · 2 comments · Fixed by #300

Comments

@anazarovflohealth
Copy link

Steps to reproduce:

Just clone repo and trying to build

git clone --recursive https://github.com/rurban/smhasher
cd smhasher; mkdir build; cd build;
cmake -Gninja .. ; ninja 

Error:

[71/75] Building CXX object CMakeFiles/SMHasherSupport.dir/PMP_Multilinear_test.cpp.o
FAILED: CMakeFiles/SMHasherSupport.dir/PMP_Multilinear_test.cpp.o 
/Applications/Xcode-15.3.0.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/bin/c++ -DHAVE_INT128 -DHAVE_INT64 -DHAVE_KHASHV  -std=c++11 -march=native -DLTO -O3 -DNDEBUG -flto=thin -arch arm64 -isysroot /Applications/Xcode-15.3.0.app/Contents/Developer/Platforms/MacOSX.platform/Developer/SDKs/MacOSX14.4.sdk -fPIC -MD -MT CMakeFiles/SMHasherSupport.dir/PMP_Multilinear_test.cpp.o -MF CMakeFiles/SMHasherSupport.dir/PMP_Multilinear_test.cpp.o.d -o CMakeFiles/SMHasherSupport.dir/PMP_Multilinear_test.cpp.o -c /Users/user/Downloads/smhasher/PMP_Multilinear_test.cpp
In file included from /Users/user/Downloads/smhasher/PMP_Multilinear_test.cpp:108:
/Users/user/Downloads/smhasher/PMP_Multilinear.h:1422:11: error: no viable overloaded '+='
      ctr += hiProduct + ( constTerm.QuadPart < lowProduct.QuadPart );
      ~~~ ^  ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
1 error generated.

CPU: Apple M1 Max
macOS version: 14.4.1
Xcode version: 15.3
clang version: clang-1500.3.9.4

@rurban
Copy link
Owner

rurban commented Apr 20, 2024

You need to tell the PMP_Multilinear author also.

@rurban
Copy link
Owner

rurban commented Aug 28, 2024

Not repro with clang++-18 and libc++ on ubuntu, sorry.

CXX='clang++ -std=c++11 -stdlib=libc++' CC=clang cmake ..

darkk added a commit to darkk/smhasher that referenced this issue Sep 2, 2024
Fixes rurban#284 by disabling PMP_Multilinear not only on aarch64, but also
on arm64. Those are the same things under different labels.
darkk added a commit to darkk/smhasher that referenced this issue Sep 6, 2024
Fixes rurban#284 by disabling PMP_Multilinear not only on aarch64, but also
on arm64. Those are the same things under different labels.
darkk added a commit to darkk/smhasher that referenced this issue Sep 27, 2024
Fixes rurban#284 by disabling PMP_Multilinear not only on aarch64, but also
on arm64. Those are the same things under different labels.
@darkk darkk mentioned this issue Sep 27, 2024
@rurban rurban closed this as completed in 3ce696d Sep 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants