Null-safety support #10
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi @R0m4in-dooz, I have started a new project to experiment with Navigator 2.0 (flouter) but i would suggest you to migrate to more robust package for Navigator 2.0 like beamer. .... 10 minutes later I looked at the code and everything looks good will try it this evening and merge it :) |
added 2 commits
August 14, 2021 17:53
|
As this pkg is used in production in our app without any issues, I added version change to 1.0.0 😁 If you want me to undo this precise change, tell me 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi @Kleak,
Here is a PR to upgrade your router pkg towards null-safety... Until it is merged, we will use our fork on our app 👍
We did the migration without the official tool for nnbd migration. If you see anything to change again, please make sure to ping us !
Regards,
@R0m4in-dooz
PS: Maybe we could also work for a version with Navigator API 2.0 ?