Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix the s_expressions example #55

Merged
merged 3 commits into from
Apr 23, 2020
Merged

Fix the s_expressions example #55

merged 3 commits into from
Apr 23, 2020

Conversation

nickolay
Copy link
Contributor

@nickolay nickolay commented Apr 22, 2020 •
edited
Loading

It was broken since the refactoring in PR #9 (v0.2.0)

@nickolay
Fix the s_expressions example
d72e678 
...broken since the refactoring in PR#9 (v0.2.0)
@nickolay
Update/expand comments in the tutorial
5546a23 
Move things around so that `SyntaxNode` and `impl Parse` are introduced
when they are needed, and not earlier.
@nickolay
Include a SyntaxNode getter in the s_exp tutorial
46d0124
@CAD97
Copy link
Collaborator

CAD97 commented Apr 23, 2020

bors: r+

@bors
Copy link
Contributor

bors bot commented Apr 23, 2020

Build succeeded:

@bors bors bot merged commit 815a5f3 into rust-analyzer:master Apr 23, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@nickolay @CAD97