Add ability to gc node caches #63
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kjeremy
reviewed
Jun 19, 2020
| nodes: FxHashSet<GreenNode>, | ||
| tokens: FxHashSet<GreenToken>, | ||
| nodes: HashMap<GreenNode, ()>, | ||
| tokens: HashMap<GreenToken, ()>, |
There was a problem hiding this comment.
Are these HashMap just because of drain_filter?
There was a problem hiding this comment.
Yes (unfortunately).
A further optimization step in the pipeline will take further advantage of HashMap::raw_entry_mut, so the switch to using set-like maps is probably inevitable, though.
|
What is the effect on peak memory usage for analysis stats using rust analyzer? |
|
It's not going to have an immediate impact because r-a doesn't (IIUC) yet hold on to or reuse node caches. Additionally, it will only potentially have an impact when holding onto a node cache after the deletion of a parse tree. We aren't really generating any garbage to clean up; it's only useful if the cache outlives the tree(s) that it's built. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Originally implemented in sorbus here: CAD97/sorbus#46
Also exposes the
NodeCache(closes #53) so that the gc is usable. WhileGreenNodeBuilderhas hadwith_cachefor a while, it's been impossible to actually share the cache, as there was no way to get a cache to share!