Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

impl try_from Range<usize> for textRange #51

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

impl try_from Range<usize> for textRange #51

wants to merge 1 commit into from

Conversation

AndyJado
Copy link

No description provided.

@matklad
Copy link
Member

matklad commented Mar 25, 2023

This makes sense, but we also need to check that start <= end.

not sure what’s the best error type here, I’d rather avoid introducing a special error type just for this…

@AndyJado
Copy link
Author

AndyJado commented Mar 25, 2023 •
edited
Loading

the error type is the same one from impl TryFrom<usize> for TextSize {

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@AndyJado @matklad