Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] Convert drfti1 to a safe version #63

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Commits on Mar 14, 2020

  1. Convert drfti1 to a safe version

    I am still not satisfied with this, but at least it can be a decent
    starting point for improvements. My points are:
    1. Variable names are still unintelligible, mainly because I do not have
    a clear vision of the algorithm. Maybe someone better than me can be
    able to grasp the meaning of each variable and to git them a decent
    name.
    2. The first loop is still unidiomatic. Everything I thought involves an
    additional check to exit the outer loop, and at the current state (no
    benchmarks) I am not sure about the best approch.
    
    Nevertheless, cast checks that were not present in the original code
    should be helpful to find strange edge cases, and they should have a
    negligible cost due to the cpu branch predictor.
    dodomorandi committed Mar 14, 2020
    Configuration menu
    Copy the full SHA
    0c3a47e View commit details
    Browse the repository at this point in the history