[RFC] Folder handeling and multi threadings #4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When developing using a docker container in VSCode it creates this dir, not something needed by others
I forgot to commit along the way so here is a large single commit...
|
Is there any update for this one? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a messy implementation not really meant to be pulled into the main branch.
I was messing around with adding support for processing entire folders for comparing videos and along the way I decided to add masic tokio based threading since ssimulacra2 is a single threaded process.
This does add two extra deps and tokio is a bloated one since I have it set to
fullright now while I mess around so it doesn't follow the desire to keep this a minimal executable.Just sharing these changes for comment and sharing of ideas.