Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is a recap of all pending changes, and a central point to track all issues that will be closed.
Refactor crate:
nom-derive
andnom-derive-impl
) so it can export public items, in particular theParse
trait. This item definition is not yet definitive, but the introduction of different methodsparse_be
andparse_le
may become essential for next versions. For ex, instead of generatingparse
for a struct, we could generate an implementation of theParse
trait (See Generate implementation ofParse
trait, instead ofparse
method #21)Parse
for primitive types, including primitive arrays (closes Support for primitive arrays #4). Also provide example of newtype pattern to specify different implementations (closes Document how to implement parsers for existing types #16)struct
andenum
()
forTag
#18), or the parse function that will be used withCount
(closes Count with Parse #9)NomBE
andNomLE
custom derive attributes have been added, and should make this fairly easy anyway (for exuse nom_derive::NomLE as Nom
) (closes Overriding the default endianness #14)where
clausesGenericErrors
attribute, to generate a function signature with generic error type (closes Context attribute #19)Except for the order of attributes, there should be no breaking change.