Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor input traits #1610

Merged
merged 3 commits into from
Jan 5, 2023
Merged

Refactor input traits #1610

merged 3 commits into from
Jan 5, 2023

Conversation

Geal
Copy link
Collaborator

@Geal Geal commented Jan 3, 2023 •
edited
Loading

experiments in simplifying input traits

@coveralls
Copy link

coveralls commented Jan 3, 2023 •
edited
Loading

Pull Request Test Coverage Report for Build 3833619782

  • 39 of 66 (59.09%) changed or added relevant lines in 5 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-0.2%) to 61.597%
Changes Missing Coverage Covered Lines Changed/Added Lines %
src/character/complete.rs 14 17 82.35%
src/traits.rs 6 30 20.0%
Totals Coverage Status
Change from base Build 3832736740: -0.2%
Covered Lines: 1551
Relevant Lines: 2518
💛 - Coveralls

@Geal
simplify InputIter: remove iter_indices
ff8cf77 
it was only used in two combinators for which an alternative
implementation can be used
@Geal Geal marked this pull request as ready for review January 5, 2023 18:20
@Geal Geal merged commit dc5601d into main Jan 5, 2023
@Geal Geal deleted the refactor-input-traits branch January 5, 2023 18:20
@Geal Geal mentioned this pull request Jan 7, 2023
Open
@epage epage mentioned this pull request Feb 1, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Geal @coveralls