Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Our Taproot parser parses tr(<key>,) as tr(<key>); we should reject it #736

Closed
apoelstra opened this issue Sep 1, 2024 · 0 comments
Closed

Our Taproot parser parses tr(<key>,) as tr(<key>); we should reject it #736

apoelstra opened this issue Sep 1, 2024 · 0 comments

Comments

@apoelstra
Copy link
Member

This is a pretty minor thing but I'd like to fix it because I want a released 12.x whose parsing behavior is identical to my rewritten-parser branch.
@apoelstra apoelstra mentioned this issue Sep 1, 2024
Open
@apoelstra apoelstra mentioned this issue Sep 1, 2024
Merged
apoelstra added a commit that referenced this issue Sep 3, 2024
@apoelstra
Merge #737: Misc compatibility-with-12.x things
b11cdc2 
1259375 miniscript: make display prefer 'u' over 'l' in the fragment l:0 (Andrew Poelstra)
67fdc50 descriptor: reject strings of the form "tr(<key>,)" (Andrew Poelstra)
00cac40 descriptor: add unit test demonstrating sanity-checking behavior in <= 12.x (Andrew Poelstra)

Pull request description:

  This PR has three changes which are mostly unrelated except that they were all found when fuzzing my "rewrite expression parser to be nonrecursive" branch against 12.x.

  * First is a unit test demonstrating #734. It doesn't fix anything, just tests the current behavior.
  * Second is a fix for #736 (backported in #735).
  * Third tweaks the new `Display` code from #722 to change how the ambiguous `l:0`/`u:0` is serialized, to match 12.x.

ACKs for top commit:
  sanket1729:
    ACK 1259375

Tree-SHA512: 921d65a1efd49bda0f9db488a2854b004e14518f584d832497a9dbc13a845ceec99544375385570c6ac42d4985277e8dcbb3aa8654de93235cf9067ba601f91d
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@apoelstra