Release tracking PR: `v12.0.0` #688

tcharding · 2024-05-16T05:34:49Z

In preparation for release add a changelog entry and bump the version.

tcharding · 2024-05-16T05:35:05Z

tcharding · 2024-05-16T22:36:24Z

@apoelstra and/or @sanket1729 can you guys please look closer than usual at the changelog entries because I don't know what goes on here as closely as I do in other crates, specifically are the sub-headings correct and/or useful? I basically included every merged PR since last release.

Thanks

storopoli

Since you've asked for eyes on the changelogs, I've added comments.
Most of these is for consistency throughout the new changelog.

storopoli · 2024-05-17T13:57:34Z

CHANGELOG.md

+
+- Update MSRV to Rust 1.56.1 [#639](https://github.com/rust-bitcoin/rust-miniscript/pull/639)
+- Drop the `Property` trait entirely [#652](https://github.com/rust-bitcoin/rust-miniscript/pull/652)
+- Improve compiler logic when deciding between conjunctions and multi/multi_a [#657](https://github.com/rust-bitcoin/rust-miniscript/pull/657)


Suggested change

- Improve compiler logic when deciding between conjunctions and multi/multi_a [#657](https://github.com/rust-bitcoin/rust-miniscript/pull/657)

- Improve compiler logic when deciding between conjunctions and `multi`/`multi_a` [#657](https://github.com/rust-bitcoin/rust-miniscript/pull/657)

storopoli · 2024-05-17T13:57:49Z

CHANGELOG.md

+- Drop the `Property` trait entirely [#652](https://github.com/rust-bitcoin/rust-miniscript/pull/652)
+- Improve compiler logic when deciding between conjunctions and multi/multi_a [#657](https://github.com/rust-bitcoin/rust-miniscript/pull/657)
+- Several locktime improvements [#654](https://github.com/rust-bitcoin/rust-miniscript/pull/654)
+- Derives `Hash` for pub items [#659](https://github.com/rust-bitcoin/rust-miniscript/pull/659)


Suggested change

- Derives `Hash` for pub items [#659](https://github.com/rust-bitcoin/rust-miniscript/pull/659)

- Derives `Hash` for `pub` items [#659](https://github.com/rust-bitcoin/rust-miniscript/pull/659)

storopoli · 2024-05-17T13:59:16Z

CHANGELOG.md

+- Drop the `Property` trait entirely [#652](https://github.com/rust-bitcoin/rust-miniscript/pull/652)
+- Improve compiler logic when deciding between conjunctions and multi/multi_a [#657](https://github.com/rust-bitcoin/rust-miniscript/pull/657)
+- Several locktime improvements [#654](https://github.com/rust-bitcoin/rust-miniscript/pull/654)
+- Derives `Hash` for pub items [#659](https://github.com/rust-bitcoin/rust-miniscript/pull/659)


Suggested change

- Derives `Hash` for pub items [#659](https://github.com/rust-bitcoin/rust-miniscript/pull/659)

- Derive `Hash` for pub items [#659](https://github.com/rust-bitcoin/rust-miniscript/pull/659)

Why all other are like "Introduce", "Upgrade", "Return" etc; and this is "Derives"

storopoli · 2024-05-17T14:00:08Z

CHANGELOG.md

+- Introduce `Threshold` type [#660](https://github.com/rust-bitcoin/rust-miniscript/pull/660), 
+  [#674](https://github.com/rust-bitcoin/rust-miniscript/pull/674),
+  and [#676](https://github.com/rust-bitcoin/rust-miniscript/pull/676)
+- Upgrade `bech32` dependency to `v0.11.0` [#661](https://github.com/rust-bitcoin/rust-miniscript/pull/661)


Either this version is non code, i.e. 0.11.0 or the MSRV Rust version above should be as code (backticks) for consistency

storopoli · 2024-05-17T14:00:23Z

CHANGELOG.md

+## Performance/compiled time improvements
+
+- Remove recursion in `semantic` module [#612](https://github.com/rust-bitcoin/rust-miniscript/pull/612)
+- Remove generics from Error by making fragment a String [#642](https://github.com/rust-bitcoin/rust-miniscript/pull/642)


Suggested change

- Remove generics from Error by making fragment a String [#642](https://github.com/rust-bitcoin/rust-miniscript/pull/642)

- Remove generics from `Error` by making fragment a `String` [#642](https://github.com/rust-bitcoin/rust-miniscript/pull/642)

storopoli · 2024-05-17T14:00:32Z

CHANGELOG.md

+
+- Remove recursion in `semantic` module [#612](https://github.com/rust-bitcoin/rust-miniscript/pull/612)
+- Remove generics from Error by making fragment a String [#642](https://github.com/rust-bitcoin/rust-miniscript/pull/642)
+- Remove unused generic on check_witness [#644](https://github.com/rust-bitcoin/rust-miniscript/pull/644)


Suggested change

- Remove unused generic on check_witness [#644](https://github.com/rust-bitcoin/rust-miniscript/pull/644)

- Remove unused generic on `check_witness` [#644](https://github.com/rust-bitcoin/rust-miniscript/pull/644)

storopoli · 2024-05-17T14:00:53Z

CHANGELOG.md

+- Remove recursion in `semantic` module [#612](https://github.com/rust-bitcoin/rust-miniscript/pull/612)
+- Remove generics from Error by making fragment a String [#642](https://github.com/rust-bitcoin/rust-miniscript/pull/642)
+- Remove unused generic on check_witness [#644](https://github.com/rust-bitcoin/rust-miniscript/pull/644)
+- Add conditional formatting for Terminal [#651](https://github.com/rust-bitcoin/rust-miniscript/pull/651)


Suggested change

- Add conditional formatting for Terminal [#651](https://github.com/rust-bitcoin/rust-miniscript/pull/651)

- Add conditional formatting for `Terminal` [#651](https://github.com/rust-bitcoin/rust-miniscript/pull/651)

storopoli · 2024-05-17T14:02:40Z

CHANGELOG.md

+
+- Remove `internals` dependency [](https://github.com/rust-bitcoin/rust-miniscript/pull/631)
+- Introduce an example binary useful for profiling [#646](https://github.com/rust-bitcoin/rust-miniscript/pull/646)
+- Refactor out type_check [#649](https://github.com/rust-bitcoin/rust-miniscript/pull/649)


Suggested change

- Refactor out type_check [#649](https://github.com/rust-bitcoin/rust-miniscript/pull/649)

- Refactor out `type_check` [#649](https://github.com/rust-bitcoin/rust-miniscript/pull/649)

tcharding · 2024-05-17T21:59:03Z

Thanks @storopoli, I'll re-spin with all your suggestions.

tcharding · 2024-05-17T23:30:26Z

Hey @storopoli man, to save you review time (which is precious) I would have accepted "you forgot to back tick all the types". But thanks for taking the time to point each out.

I also discovered a set of empty [] - so that's a win!

tcharding · 2024-05-17T23:33:20Z

All yours @apoelstra - review, ack, merge, tag, and publish please (if the changelog is acceptable).

apoelstra · 2024-05-20T14:00:37Z

CHANGELOG.md

+- Improve compiler logic when deciding between conjunctions and `multi`/`multi_a` [#657](https://github.com/rust-bitcoin/rust-miniscript/pull/657)
+- Several locktime improvements [#654](https://github.com/rust-bitcoin/rust-miniscript/pull/654)
+- Derive `Hash` for `pub` items [#659](https://github.com/rust-bitcoin/rust-miniscript/pull/659)
+- Introduce `Threshold` type [#660](https://github.com/rust-bitcoin/rust-miniscript/pull/660), 


In 7ddaaf6:

Trailing whitespace, and also a trailing comma.

Fixed.

\me Puts coin in money jar for not reading diff before pushing

That jar is getting full... Reminds me a calculus teacher that had a jar of coins for everytime that a student forgot to add $c$ to an integration procedure 😂

I had a swear jar once but it got full so quick I stopped. Now we do 5 pushups each time instead - works way better.

Ha! Just did five push ups and said "read your diff" at the top of each one - lets see how it goes.

apoelstra · 2024-05-20T14:10:13Z

Should definitely mention #645 which increases the set of allowable scripts.

#660 #674 #678 should get their own section since these are a major breaking change that will probably break anybody who is manually constructing Miniscripts using thresholds.

tcharding · 2024-05-21T22:49:44Z

Note, I did not rebase on master so this excludes the shellcheck CI job patch.

tcharding · 2024-05-21T22:50:11Z

Also, added #645 but did not add additional explanation - ok?

tcharding · 2024-05-21T22:50:32Z

# 12.0.0 - May 17, 2024

- Update MSRV to Rust `v1.56.1` [#639](https://github.com/rust-bitcoin/rust-miniscript/pull/639)
- Remove sketchy `LikelyFalse` error [#645](https://github.com/rust-bitcoin/rust-miniscript/pull/645)

In preparation for release add a changelog entry and bump the version.

tcharding · 2024-05-21T22:50:58Z

Updated date to 22nd

apoelstra

ACK 5ea33e3

apoelstra · 2024-05-22T19:58:01Z

Tagged and published.

tcharding force-pushed the 05-16-release-12.0.0 branch from 532f314 to f2a61ad Compare May 16, 2024 22:33

tcharding changed the title ~~Bump version to 12.0.0~~ Release tracking PR: v12.0.0 May 16, 2024

storopoli reviewed May 17, 2024

View reviewed changes

tcharding force-pushed the 05-16-release-12.0.0 branch from f2a61ad to 15e3d8a Compare May 17, 2024 23:29

tcharding force-pushed the 05-16-release-12.0.0 branch from 15e3d8a to 7ddaaf6 Compare May 17, 2024 23:31

tcharding marked this pull request as ready for review May 17, 2024 23:32

tcharding mentioned this pull request May 17, 2024

Test the bitcoin v0.32.0-rc1 release bitcoindevkit/bdk#1400

Closed

apoelstra reviewed May 20, 2024

View reviewed changes

tcharding force-pushed the 05-16-release-12.0.0 branch from 7ddaaf6 to df113f6 Compare May 21, 2024 22:48

Bump version to 12.0.0

5ea33e3

In preparation for release add a changelog entry and bump the version.

tcharding force-pushed the 05-16-release-12.0.0 branch from df113f6 to 5ea33e3 Compare May 21, 2024 22:50

apoelstra approved these changes May 22, 2024

View reviewed changes

apoelstra merged commit 9e1b3cd into rust-bitcoin:master May 22, 2024
8 checks passed

tcharding deleted the 05-16-release-12.0.0 branch July 16, 2024 22:59

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Release tracking PR: `v12.0.0` #688

Release tracking PR: `v12.0.0` #688

tcharding commented May 16, 2024 •

edited

Loading

tcharding commented May 16, 2024

tcharding commented May 16, 2024

storopoli left a comment

storopoli May 17, 2024

storopoli May 17, 2024

storopoli May 17, 2024

storopoli May 17, 2024

storopoli May 17, 2024

storopoli May 17, 2024

storopoli May 17, 2024

storopoli May 17, 2024

tcharding commented May 17, 2024

tcharding commented May 17, 2024 •

edited

Loading

tcharding commented May 17, 2024

apoelstra May 20, 2024

tcharding May 21, 2024

storopoli May 21, 2024

tcharding May 21, 2024

tcharding May 21, 2024

apoelstra commented May 20, 2024

tcharding commented May 21, 2024

tcharding commented May 21, 2024

tcharding commented May 21, 2024

tcharding commented May 21, 2024

apoelstra left a comment

apoelstra commented May 22, 2024

	- Improve compiler logic when deciding between conjunctions and multi/multi_a [#657](https://github.com/rust-bitcoin/rust-miniscript/pull/657)
	- Improve compiler logic when deciding between conjunctions and `multi`/`multi_a` [#657](https://github.com/rust-bitcoin/rust-miniscript/pull/657)

	- Derives `Hash` for pub items [#659](https://github.com/rust-bitcoin/rust-miniscript/pull/659)
	- Derives `Hash` for `pub` items [#659](https://github.com/rust-bitcoin/rust-miniscript/pull/659)

	- Derives `Hash` for pub items [#659](https://github.com/rust-bitcoin/rust-miniscript/pull/659)
	- Derive `Hash` for pub items [#659](https://github.com/rust-bitcoin/rust-miniscript/pull/659)

	- Remove generics from Error by making fragment a String [#642](https://github.com/rust-bitcoin/rust-miniscript/pull/642)
	- Remove generics from `Error` by making fragment a `String` [#642](https://github.com/rust-bitcoin/rust-miniscript/pull/642)

	- Remove unused generic on check_witness [#644](https://github.com/rust-bitcoin/rust-miniscript/pull/644)
	- Remove unused generic on `check_witness` [#644](https://github.com/rust-bitcoin/rust-miniscript/pull/644)

	- Add conditional formatting for Terminal [#651](https://github.com/rust-bitcoin/rust-miniscript/pull/651)
	- Add conditional formatting for `Terminal` [#651](https://github.com/rust-bitcoin/rust-miniscript/pull/651)

	- Refactor out type_check [#649](https://github.com/rust-bitcoin/rust-miniscript/pull/649)
	- Refactor out `type_check` [#649](https://github.com/rust-bitcoin/rust-miniscript/pull/649)

Release tracking PR: v12.0.0 #688

Release tracking PR: v12.0.0 #688

Conversation

tcharding commented May 16, 2024 • edited Loading

tcharding commented May 16, 2024

tcharding commented May 16, 2024

storopoli left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

tcharding commented May 17, 2024

tcharding commented May 17, 2024 • edited Loading

tcharding commented May 17, 2024

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

apoelstra commented May 20, 2024

tcharding commented May 21, 2024

tcharding commented May 21, 2024

tcharding commented May 21, 2024

tcharding commented May 21, 2024

apoelstra left a comment

Choose a reason for hiding this comment

apoelstra commented May 22, 2024

Release tracking PR: `v12.0.0` #688

Release tracking PR: `v12.0.0` #688

tcharding commented May 16, 2024 •

edited

Loading

tcharding commented May 17, 2024 •

edited

Loading