Remove unnecessary code comment #666
Conversation
| for (i, byte) in fake_signature_data.iter_mut().enumerate() { | ||
| // up to MAX_LEN |
There was a problem hiding this comment.
This was meant as justification why as is OK. :)
There was a problem hiding this comment.
Oh, I didn't read it as such, my bad. I can re-work this and improve instead of remove the comment.
There was a problem hiding this comment.
Both options sound fine to me.
There was a problem hiding this comment.
It should be on the same line as the as so that it's visible with grep.
rustfmt might fuck it up; see the most recent rustfmt fight in which inline comments were described as "weird" and "C like". But hopefully not.
There was a problem hiding this comment.
Well, that's at least uncommon. And you can give grep context. Although I do think it'd be nice if Rust folks were more welcoming towards people who need to document their code this way. ;)
tcharding
force-pushed
the
11-14-remove-code-comments
branch
from
e3daddd
to
2a783e3
Compare
"what" comments add no value. Remove one and make the other describe "why" the cast is ok.
tcharding
force-pushed
the
11-14-remove-code-comments
branch
from
2a783e3
to
4587122
Compare
These comments say what the code is doing, they add no value.