Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

secp256k1-sys: Bump version to 0.9.1 #668

Merged
merged 1 commit into from
Dec 6, 2023

Conversation

tcharding
Copy link
Member

@tcharding tcharding commented Dec 6, 2023

In preparation for doing a point release add a changelog entry, bump the version, and update all the 0_9_0 identifiers in the vendored code.

Done so we can release the wasm-build bug fix.

Fix: #667

In preparation for doing a point release add a changelog entry, bump the
version, and update all the `0_9_0` identifiers in the vendored code.

Done so we can release the wasm-build bug fix.
@tcharding
Copy link
Member Author

tcharding commented Dec 6, 2023

The diff is massive, so you know what I did:

  • s/0_9_0/0_9_1/g
  • grepped for '0.9.0' and changed those than needed it
  • added the changelog
  • used the update script in rust-bitcoin to update the lock files
  • depended on the new version of secp-sys in secp manifest

Copy link
Member

@apoelstra apoelstra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK c1ccda1

@apoelstra
Copy link
Member

Neat. I'm a little surprised this worked with you just search-and-replacing strings like this. The correct way is to re-run the vendoring script.

@apoelstra apoelstra merged commit 97dade5 into rust-bitcoin:master Dec 6, 2023
20 checks passed
@apoelstra
Copy link
Member

Tagged and published.

@tcharding
Copy link
Member Author

tcharding commented Dec 6, 2023

I'm a little surprised this worked with you just search-and-replacing strings like this. The correct way is to re-run the vendoring script.

lol, perl oneliner'ed my way to fame ;)

@tcharding tcharding deleted the 12-07-release-secp-sys branch March 25, 2024 21:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

secp256k1-sys v0.9.0 does not support wasm32-unknown-unknown, how to fix this problem?
2 participants