perf: avoid using write! macro with single str

rust-cli · Nov 1, 2024 · fb843c5 · fb843c5
1 parent 5628f47
commit fb843c5
Show file tree

Hide file tree

Showing 3 changed files with 6 additions and 9 deletions.
diff --git a/crates/anstyle/src/color.rs b/crates/anstyle/src/color.rs
@@ -627,19 +627,17 @@ impl DisplayBuffer {
 impl core::fmt::Display for DisplayBuffer {
     #[inline]
     fn fmt(&self, f: &mut core::fmt::Formatter<'_>) -> core::fmt::Result {
-        let s = self.as_str();
-        write!(f, "{s}")
+        f.write_str(self.as_str())
     }
 }
 
 #[derive(Copy, Clone, Default, Debug)]
-struct NullFormatter<D: core::fmt::Display>(D);
+struct NullFormatter(&'static str);
 
-impl<D: core::fmt::Display> core::fmt::Display for NullFormatter<D> {
+impl core::fmt::Display for NullFormatter {
     #[inline]
     fn fmt(&self, f: &mut core::fmt::Formatter<'_>) -> core::fmt::Result {
-        let d = &self.0;
-        write!(f, "{d}")
+        f.write_str(self.0)
     }
 }
 

diff --git a/crates/anstyle/src/effect.rs b/crates/anstyle/src/effect.rs
@@ -323,8 +323,7 @@ impl core::fmt::Display for EffectsDisplay {
     #[inline]
     fn fmt(&self, f: &mut core::fmt::Formatter<'_>) -> core::fmt::Result {
         for index in self.0.index_iter() {
-            let escape = METADATA[index].escape;
-            write!(f, "{escape}")?;
+            f.write_str(METADATA[index].escape)?;
         }
         Ok(())
     }

diff --git a/crates/anstyle/src/reset.rs b/crates/anstyle/src/reset.rs
@@ -15,7 +15,7 @@ impl Reset {
 
 impl core::fmt::Display for Reset {
     fn fmt(&self, f: &mut core::fmt::Formatter<'_>) -> core::fmt::Result {
-        write!(f, "{RESET}")
+        f.write_str(RESET)
     }
 }