fix(stream): Don't break out of UTF8 character part-way #158
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This fixes a soundness issue where we create invalid UTF-8 data and then do a `str::from_unchecked` on release builds. This ensures we ignore up-to the start of UTF-8 sequences and not mid-way through. Fixes rust-cli#156
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes a soundness issue where we create invalid UTF-8 data and then
do a
str::from_uncheckedon release builds.This ensures we ignore up-to the start of UTF-8 sequences and not
mid-way through.
We need to find more ways to prop test this to help catch issues like this.
This supersedes #157
Fixes #156