Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

A slightly better approach to add weak symbols to the build for musl 1.2.4 #172

Merged
merged 1 commit into from
Sep 10, 2023

Conversation

haohaolee
Copy link
Contributor

  • Add rust version check since rust 1.72 fixes the weak symbol issues for musl
  • Use a linker script to add missing symbols during linking for zig >= 0.11 and rust < 1.72 (it should be better than using rust-lld since we can use the old logic to adjust parameters passed to zig )

Copy link
Member

@messense messense left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@messense messense merged commit fc2a082 into rust-cross:main Sep 10, 2023
37 of 39 checks passed
@messense
Copy link
Member

Hi, I've invited you to join rust-cross organization to co-maintain cargo-zigbuild in recognition of your contributions, thanks!

@haohaolee
Copy link
Contributor Author

Thanks for inviting me.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants