Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Skip rust-bindgen test case on Rust 1.74.0 #270

Merged
merged 3 commits into from
Sep 18, 2024
Merged

Skip rust-bindgen test case on Rust 1.74.0 #270

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
d600124
Filter out `-lmsvcrt` for Windows gnu targets
messense Aug 25, 2024
ebf92bc
Revert `-lmsvcrt` change
messense Sep 18, 2024
780c68a
Update CI.yml
messense Sep 18, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 4 additions & 3 deletions .github/workflows/CI.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -71,6 +71,8 @@ jobs:
x86_64-pc-windows-gnu \
i686-pc-windows-gnu
- name: Test bindgen
# zstd with bindgen requires Rust 1.77+
if: ${{ matrix.toolchain != '1.74.0' }}
shell: bash
run: |
set -e
Expand Down Expand Up @@ -134,7 +136,7 @@ jobs:
cargo run zigbuild --target aarch64-apple-darwin --manifest-path tests/hello-tls/Cargo.toml
cargo run zigbuild --target aarch64-apple-darwin --manifest-path tests/hello-rustls/Cargo.toml
- name: macOS - Test build bindgen with SDKROOT
if: ${{ matrix.os == 'ubuntu-latest' && matrix.toolchain != '1.67.0' }}
if: ${{ matrix.os == 'ubuntu-latest' && matrix.toolchain != '1.74.0' }}
env:
SDK: MacOSX11.3.sdk
run: cargo run zigbuild --manifest-path tests/zstd-rs/Cargo.toml --features bindgen --target aarch64-apple-darwin
Expand Down Expand Up @@ -190,7 +192,6 @@ jobs:
cargo run zigbuild --target aarch64-unknown-linux-musl
cargo run zigbuild --target aarch64-unknown-linux-musl --manifest-path tests/hello-rustls/Cargo.toml
- name: Windows - Test gnu build
if: matrix.zig != '0.13.0'
run: |
cargo run zigbuild --target x86_64-pc-windows-gnu
cargo run zigbuild --target x86_64-pc-windows-gnu --manifest-path tests/hello-windows/Cargo.toml
Expand All @@ -201,7 +202,7 @@ jobs:
run: |
cargo run zigbuild --target aarch64-unknown-linux-gnu --manifest-path tests/hello-rustls/Cargo.toml --features curl
- name: Windows - Test run
if: ${{ matrix.os == 'windows-latest' && matrix.zig != '0.13.0' }}
if: ${{ matrix.os == 'windows-latest' }}
run: |
./target/x86_64-pc-windows-gnu/debug/cargo-zigbuild.exe zigbuild --help
./tests/hello-windows/target/x86_64-pc-windows-gnu/debug/hello-windows.exe
Expand Down
Loading