make Serializer and Deserializer pub and usable #72
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is required when using serde_json_core with code that is generic over the serde implementation, i.e. code that wants to instantiate the Serializer/Deserializer, in the way done in `de::from_slice` and `ser::to_slice`. This also adds public getters for the Serializer.current_length and Deserializer.index members. Two obsolete/unused impls on the `Unreachable` have been removed.
jordens
changed the title
eldruin
reviewed
Jul 24, 2023
|
No. Might be dependencies. You may be using your own older Cargo.lock. |
|
A sufficient set of dependency updates that includes the breaking change are these: |
|
All runs fine on 1.56.0. Could you update the MSRV to 1.56.0? |
there is a MSRV bump somwhere in this dependency bump:
Updating proc-macro2 v1.0.47 -> v1.0.66
Updating quote v1.0.23 -> v1.0.32
Updating serde v1.0.100 -> v1.0.175
Updating serde_derive v1.0.100 -> v1.0.175
Updating syn v1.0.109 -> v2.0.27
|
Great, sorry but could you also update the MSRV in the README? |
|
Also |
eldruin
approved these changes
Jul 24, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is required when using serde_json_core with code that is
generic over the serde implementation, i.e. code that wants to
instantiate the Serializer/Deserializer, in the way done in
de::from_sliceandser::to_slice.This also adds public getters for the Serializer.current_length
and Deserializer.index members.
Two obsolete/unused impls on the
Unreachablehave been removed.