Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Type-level display size #125

Merged
merged 21 commits into from
Jun 23, 2020
Merged

Type-level display size #125

merged 21 commits into from
Jun 23, 2020

Commits on Jun 13, 2020

  1. Sketch up type-level display size

    @bugadani
    Dániel Buga authored and bugadani committed Jun 13, 2020
    Configuration menu
    Copy the full SHA
    45e3f8d View commit details
    Browse the repository at this point in the history

  2. Use display buffers with only the necessary size

    @bugadani
    Dániel Buga authored and bugadani committed Jun 13, 2020
    Configuration menu
    Copy the full SHA
    9221aa9 View commit details
    Browse the repository at this point in the history

  3. Run cargo fmt

    @bugadani
    Dániel Buga authored and bugadani committed Jun 13, 2020
    Configuration menu
    Copy the full SHA
    cd9e24d View commit details
    Browse the repository at this point in the history

  4. Make the module public

    @bugadani
    bugadani committed Jun 13, 2020
    Configuration menu
    Copy the full SHA
    b53ef58 View commit details
    Browse the repository at this point in the history

  5. Add defaults 

    Try to at least be backwards compatible when the defaults are used
    @bugadani
    bugadani committed Jun 13, 2020
    Configuration menu
    Copy the full SHA
    ea46e9f View commit details
    Browse the repository at this point in the history

  6. Implemented suggested changes

    @bugadani
    bugadani committed Jun 13, 2020
    Configuration menu
    Copy the full SHA
    3478024 View commit details
    Browse the repository at this point in the history

  7. Command must be public to allow external implementations of DisplaySize

    @bugadani
    bugadani committed Jun 13, 2020
    Configuration menu
    Copy the full SHA
    13e6807 View commit details
    Browse the repository at this point in the history

  8. Docs to make CI happy

    @bugadani
    bugadani committed Jun 13, 2020
    Configuration menu
    Copy the full SHA
    ee64523 View commit details
    Browse the repository at this point in the history

  9. Run cargo fmt

    @bugadani
    bugadani committed Jun 13, 2020
    Configuration menu
    Copy the full SHA
    4e1f1e1 View commit details
    Browse the repository at this point in the history

  10. Fix inference related errors, add display sizes to prelude

    @bugadani
    bugadani committed Jun 13, 2020
    Configuration menu
    Copy the full SHA
    c87abe2 View commit details
    Browse the repository at this point in the history

  11. Fix formatting

    @bugadani
    bugadani committed Jun 13, 2020
    Configuration menu
    Copy the full SHA
    a0bdbab View commit details
    Browse the repository at this point in the history

  12. Fix examples in doc comments

    @bugadani
    bugadani committed Jun 13, 2020
    Configuration menu
    Copy the full SHA
    828b6ec View commit details
    Browse the repository at this point in the history

  13. Looks like we need to be explicit with the types

    @bugadani
    bugadani committed Jun 13, 2020
    Configuration menu
    Copy the full SHA
    c51b4a1 View commit details
    Browse the repository at this point in the history

  14. Modify configuration to send the command instead of just constructing it 

    This will align better with rotation where at least two commands must be transmitted for configuration
    @bugadani
    bugadani committed Jun 13, 2020
    Configuration menu
    Copy the full SHA
    7529a8c View commit details
    Browse the repository at this point in the history

Commits on Jun 16, 2020

  1. Cleanup

    @bugadani
    bugadani committed Jun 16, 2020
    Configuration menu
    Copy the full SHA
    748f8ce View commit details
    Browse the repository at this point in the history

  2. Remove outdated todo

    @bugadani
    bugadani committed Jun 16, 2020
    Configuration menu
    Copy the full SHA
    7293e42 View commit details
    Browse the repository at this point in the history

  3. No glob reexport

    @bugadani
    bugadani committed Jun 16, 2020
    Configuration menu
    Copy the full SHA
    f988370 View commit details
    Browse the repository at this point in the history

  4. Add note about second type param, add properties to prelude

    @bugadani
    bugadani committed Jun 16, 2020
    Configuration menu
    Copy the full SHA
    3f0ab04 View commit details
    Browse the repository at this point in the history

  5. Add changelog entry

    @bugadani
    bugadani committed Jun 16, 2020
    Configuration menu
    Copy the full SHA
    272f686 View commit details
    Browse the repository at this point in the history

  6. Fix resetting the dirty drawing area coordinates

    @bugadani
    bugadani committed Jun 16, 2020
    Configuration menu
    Copy the full SHA
    de23b05 View commit details
    Browse the repository at this point in the history

Commits on Jun 23, 2020

  1. Apply suggestions from code review 

    Co-authored-by: James Waples <[email protected]>
    @bugadani @jamwaffles
    bugadani and jamwaffles committed Jun 23, 2020
    Configuration menu
    Copy the full SHA
    48c490f View commit details
    Browse the repository at this point in the history