Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New, more consistent terminal font #137

Merged
merged 5 commits into from
Dec 1, 2020
Merged

New, more consistent terminal font #137

merged 5 commits into from
Dec 1, 2020

Conversation

jamwaffles
Copy link
Collaborator

@jamwaffles jamwaffles commented Oct 21, 2020

Hi! Thank you for helping out with SSD1306 development! Please:

  • Check that you've added documentation to any new methods
  • Rebase from master if you're not already up to date
  • Add or modify an example if there are changes to the public API
  • Add a CHANGELOG.md entry in the Unreleased section under the appropriate heading (Added, Fixed, Changed, etc)
  • Run rustfmt on the project with cargo fmt --all - CI will not pass without this step
  • Check that your branch is up to date with master and that CI is passing once the PR is opened

PR description

This font is taken from the ATIx_550_8x8.png font image from the
romfonts repo. I picked it because it looks nice, but that's subjective. It looks like this:

I don't have hardware to test with tat the moment so I might have messed
up the character mappings. I'd appreciate if someone could test on a
physical display and see how this looks.

I'm not including any of the special characters defined in that font. If
we want to add them, I'd suggest we do that in a future PR.

Closes #135

This font is taken from the ATIx_550_8x8.png font image from the
romfonts repo. A bitmap can be found here:
https://github.com/spacerace/romfont/blob/master/font-images/ATIx550_8x8.png

I don't have hardware to test with tat the moment so I might have messed
up the character mappings. I'd appreciate if someone could test on a
physical display and see how this looks.

I'm not including any of the special characters defined in that font. If
we want to add them, I'd suggest we do that in a future PR.

Closes #135
@therealprof
Copy link
Collaborator

This font is taken from the ATIx_550_8x8.png font image from the
romfonts repo.

Could there be a copyright issue?

It's certainly very retro. ;)

@jamwaffles
Copy link
Collaborator Author

Yeah, I did think about copyright but decided to use it anyway 😬.
Should we continue with the current choice anyway?

The Uzebox wiki has some alternative 8x8 fonts but a) "Some may still be under copyright" and b) I can't be bothered to turn the bitmaps into hex :(

@therealprof
Copy link
Collaborator

Have you checked out sites like: https://jared.geek.nz/2014/jan/custom-fonts-for-microcontrollers ?

@jamwaffles
Copy link
Collaborator Author

I haven't, thanks for the link! Any idea what the copyright is like? I'll have a look through those fonts and find something suitable.

@jamwaffles
Copy link
Collaborator Author

Honestly, none of them look that good. I'm ok going with the original font for now.

@jamwaffles
Copy link
Collaborator Author

I took some time to switch to zxpix from https://jared.geek.nz/2014/jan/custom-fonts-for-microcontrollers. It's converted from TTF to bitmap, so there were some artifacts in a few of the characters, mostly the lowercase ones. I've fixed those manually. Licensing shouldn't be an issue now.

@jamwaffles
Copy link
Collaborator Author

image

Looks like this now.

@jamwaffles jamwaffles merged commit 67107fd into master Dec 1, 2020
@jamwaffles jamwaffles deleted the new-terminal-font branch December 1, 2020 12:09
@therealprof
Copy link
Collaborator

Nice! 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Inconsistent Uppercase Font in Terminal Mode
2 participants