Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix BufferedGraphicsMode::clear() so that it fills all pixels #201

Merged
merged 3 commits into from
Oct 27, 2023

Conversation

zyla
Copy link
Contributor

@zyla zyla commented Oct 27, 2023

Hi! Thank you for helping out with SSD1306 development! Please:

  • Check that you've added documentation to any new methods
  • Rebase from master if you're not already up to date
  • Add or modify an example if there are changes to the public API
  • Add a CHANGELOG.md entry in the Unreleased section under the appropriate heading (Added, Fixed, Changed, etc)
  • Run rustfmt on the project with cargo fmt --all - CI will not pass without this step
  • Check that your branch is up to date with master and that CI is passing once the PR is opened

PR description

Currently clear() fills the buffer with 0x01 bytes, which represent
7 dark pixels and 1 bright pixel. We want all pixels bright. This PR fixes it by filling buffer with 0xff.

Currently `clear()` fills the buffer with `0x01` bytes, which represent
7 dark pixels and 1 bright pixel. We want all pixels bright.
Copy link
Collaborator

@jamwaffles jamwaffles left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Well spotted. Thanks!

@jamwaffles jamwaffles merged commit fe8d1f0 into rust-embedded-community:master Oct 27, 2023
8 checks passed
@jamwaffles
Copy link
Collaborator

This is released in 0.8.4. cargo update should pull the change in.

@zyla
Copy link
Contributor Author

zyla commented Oct 27, 2023

Thanks, that was very fast!

zyla added a commit to jborkowski/esp-jokes-rs that referenced this pull request Oct 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants