Skip to content
This repository has been archived by the owner on Jan 24, 2022. It is now read-only.

0.6.8 release #184

Merged
merged 2 commits into from
Apr 2, 2019
Merged

0.6.8 release #184

merged 2 commits into from
Apr 2, 2019

Conversation

korken89
Copy link
Contributor

No description provided.

@korken89 korken89 requested a review from a team as a code owner March 18, 2019 18:59
@rust-highfive
Copy link

Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @therealprof (or someone else) soon.

If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. Due to the way GitHub handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes.

Please see the contribution instructions for more information.

thejpster
thejpster previously approved these changes Mar 18, 2019
View reviewed changes
@thejpster
Copy link
Contributor

@bors r+

@korken89
Copy link
Contributor Author

@thejpster I think you have to write bors r+ without the @ :)

@korken89
Copy link
Contributor Author

I pulled in the fix for the FPU flag so we don't have to do an extra release.

r? @rust-embedded/cortex-m

@korken89
Copy link
Contributor Author

Hmm, compiletest-rs seems to have broken with the latest nightly.

@korken89
Copy link
Contributor Author

Discussion here: Manishearth/compiletest-rs#166

@korken89 korken89 requested a review from thejpster March 25, 2019 07:52
@thejpster
Copy link
Contributor

How's it going?

@therealprof
Copy link
Contributor

bors try

bors bot added a commit that referenced this pull request Apr 2, 2019
@bors
Try #184:
a6581ff
therealprof
therealprof approved these changes Apr 2, 2019
View reviewed changes
Copy link
Contributor

@therealprof therealprof left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

therealprof
therealprof suggested changes Apr 2, 2019
View reviewed changes
CHANGELOG.md Outdated Show resolved Hide resolved
therealprof
therealprof approved these changes Apr 2, 2019
View reviewed changes
Copy link
Contributor

@therealprof therealprof left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Now LGTM. ;)

@therealprof
Copy link
Contributor

bors r+

bors bot added a commit that referenced this pull request Apr 2, 2019
@bors @korken89 @therealprof
Merge #184
9859fa1 
184: 0.6.8 release r=therealprof a=korken89



Co-authored-by: Emil Fresk <[email protected]>
Co-authored-by: Daniel Egger <[email protected]>
@bors
Copy link
Contributor

bors bot commented Apr 2, 2019

Build succeeded

@bors bors bot merged commit 7e9f8af into master Apr 2, 2019
@bors bors bot deleted the 0.6.8_release branch April 2, 2019 21:44
@bors
Copy link
Contributor

bors bot commented Dec 28, 2019

try

Merge conflict

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@therealprof therealprof therealprof approved these changes

@thejpster thejpster Awaiting requested review from thejpster

Assignees
No one assigned
Labels
T-cortex-m
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@korken89 @rust-highfive @thejpster @therealprof