Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

v1.0.0 alpha release #219

Merged
merged 2 commits into from
Jun 16, 2020
Merged

v1.0.0 alpha release #219

merged 2 commits into from
Jun 16, 2020

Conversation

ryankurte
Copy link
Contributor

@ryankurte ryankurte commented Jun 10, 2020

🎉🎊🥳

See #177 for progress on blocking issues

@ryankurte ryankurte requested review from ilya-epifanov and a team as code owners June 10, 2020 02:40
@ryankurte ryankurte self-assigned this Jun 10, 2020
@luojia65
Copy link
Contributor

luojia65 commented Jun 10, 2020

Should we deal with all design pattern issues and pull requests before a probable 1.0 release? After 1.0, they would be no longer changed. May discuss on each of them and close or accept all possible designs.

@ryankurte
Copy link
Contributor Author

Ideally yep, see #177 for the list, mostly predicated on coming to a consensus as to #172 (and #98) as you mentioned in the chat.

However, I don't think this necessarily needs to block an alpha release, and there's a balance to be struct somewhere between avoiding breaking releases while not blocking e-h improvements indefinitely :-/

@luojia65
Copy link
Contributor

Ohh yes, do not need to block alpha here. Just block before the final 1.0.0 :)

@Disasm
Copy link
Member

Disasm commented Jun 10, 2020

I think that the only thing that should block v1.0.0 is rust-embedded/wg#435. We can add all the other changes after this release. embedded-hal project is already moving extremely slow, so it's better not to block it for one more reason. This async story began just recently and I do not expect it to end in the coming year.

Also I don't understand why we need v1.0.0-alpha-1 and not just v1.0.0. We can use v1.0.0 and v1.0.1 instead if we expect any non-breaking changes soon.

@luojia65
Copy link
Contributor

Yes, I agree. There should be no more blocks here

@therealprof
Copy link
Contributor

Also I don't understand why we need v1.0.0-alpha-1 and not just v1.0.0. We can use v1.0.0 and v1.0.1 instead if we expect any non-breaking changes soon.

The idea is to shake out some kinks before doing the final release. Hopefully there're no breaking changing but at the moment it's hard to say since its non-trivial to test with the required level of scrutiny without having a crate on crates.io since you get all kinds of versioning funnyness when using traits from an unreleased crate in other crates. I could even see folks follow suit by releasing alpha versions of adapted crates so we could properly level up the whole ecosystem at once.

CHANGELOG.md Outdated Show resolved Hide resolved
Copy link
Contributor

@therealprof therealprof left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Need to figure out what to do about CHANGELOG.md

@ryankurte
Copy link
Contributor Author

turns out i can't approve this because it's my pr, but, lgtm~!

@therealprof
Copy link
Contributor

bors r+

@bors bors bot merged commit 036cfa4 into master Jun 16, 2020
@bors bors bot deleted the v1.0.0-alpha.1-updates branch June 16, 2020 01:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-waiting-on-review Review is incomplete T-hal
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants