-
Notifications
You must be signed in to change notification settings - Fork 201
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
v1.0.0 alpha release #219
v1.0.0 alpha release #219
Conversation
Should we deal with all design pattern issues and pull requests before a probable 1.0 release? After 1.0, they would be no longer changed. May discuss on each of them and close or accept all possible designs. |
Ideally yep, see #177 for the list, mostly predicated on coming to a consensus as to #172 (and #98) as you mentioned in the chat. However, I don't think this necessarily needs to block an alpha release, and there's a balance to be struct somewhere between avoiding breaking releases while not blocking e-h improvements indefinitely :-/ |
Ohh yes, do not need to block alpha here. Just block before the final 1.0.0 :) |
I think that the only thing that should block v1.0.0 is rust-embedded/wg#435. We can add all the other changes after this release. Also I don't understand why we need |
Yes, I agree. There should be no more blocks here |
The idea is to shake out some kinks before doing the final release. Hopefully there're no breaking changing but at the moment it's hard to say since its non-trivial to test with the required level of scrutiny without having a crate on crates.io since you get all kinds of versioning funnyness when using traits from an unreleased crate in other crates. I could even see folks follow suit by releasing alpha versions of adapted crates so we could properly level up the whole ecosystem at once. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Need to figure out what to do about CHANGELOG.md
Signed-off-by: Daniel Egger <[email protected]>
turns out i can't approve this because it's my pr, but, lgtm~! |
bors r+ |
🎉🎊🥳
See #177 for progress on blocking issues