Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Controller Area Network (CAN) Take 4 #314

Merged
merged 10 commits into from
Oct 28, 2021
Merged

Controller Area Network (CAN) Take 4 #314

merged 10 commits into from
Oct 28, 2021
+278 −6

Commits on Oct 20, 2021

  1. Traits for CAN (Controller Area Network)

    @timokroeger
    timokroeger committed Oct 20, 2021
    Configuration menu
    Copy the full SHA
    7558350 View commit details
    Browse the repository at this point in the history

  2. can: Make Id::new_unchecked() safe 

    Invalid CAN identifiers are still memory safe.
    @timokroeger
    timokroeger committed Oct 20, 2021
    Configuration menu
    Copy the full SHA
    b2d00d1 View commit details
    Browse the repository at this point in the history

  3. can: Rename blocking methods 

    The blocking traits borrowed the naming convention from socketcan.
Rename the methods to `transmit()` and `receive()` to make them
consistent with the `nb` traits.
    @timokroeger
    timokroeger committed Oct 20, 2021
    Configuration menu
    Copy the full SHA
    5f8ed23 View commit details
    Browse the repository at this point in the history

  4. can: Add error traits like rust-embedded#296

    @timokroeger
    timokroeger committed Oct 20, 2021
    Configuration menu
    Copy the full SHA
    5f7cd3b View commit details
    Browse the repository at this point in the history

  5. can: Changelog entry

    @timokroeger
    timokroeger committed Oct 20, 2021
    Configuration menu
    Copy the full SHA
    402f1cf View commit details
    Browse the repository at this point in the history

  6. can: Add Other error kind

    @timokroeger
    timokroeger committed Oct 20, 2021
    Configuration menu
    Copy the full SHA
    6a6ad3f View commit details
    Browse the repository at this point in the history

  7. can: Rename 'Ack' error to 'Acknowledge'

    @timokroeger
    timokroeger committed Oct 20, 2021
    Configuration menu
    Copy the full SHA
    6b3820e View commit details
    Browse the repository at this point in the history

Commits on Oct 25, 2021

  1. can: Make ExtendedId::new_unchecked() safe 

    Invalid CAN identifiers are still memory safe.
    @timokroeger
    timokroeger committed Oct 25, 2021
    Configuration menu
    Copy the full SHA
    31eabd5 View commit details
    Browse the repository at this point in the history

Commits on Oct 26, 2021

  1. Revert "can: Make new_unchecked() safe" 

    This reverts commit b2d00d1 and
31eabd5.

Mark the constructor as unsafe again to prevent UB in safe code that assumes the CAN IDs to contain valid data.
This is in line with functions like `from_utf8_unchecked()` from the std library.
    @timokroeger
    timokroeger committed Oct 26, 2021
    Configuration menu
    Copy the full SHA
    1f43e5d View commit details
    Browse the repository at this point in the history

  2. Raise MSRV to Rust 1.46.0

    @timokroeger
    timokroeger committed Oct 26, 2021
    Configuration menu
    Copy the full SHA
    7387323 View commit details
    Browse the repository at this point in the history