Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

always trim whitespaces #229

Merged
merged 1 commit into from
Sep 16, 2023
Merged

always trim whitespaces #229

merged 1 commit into from
Sep 16, 2023

Conversation

burrbull
Copy link
Member

No description provided.

@burrbull burrbull requested a review from a team as a code owner September 16, 2023 08:03
@burrbull
Copy link
Member Author

burrbull commented Sep 16, 2023 •
edited
Loading

cc @Emilgardis
I see 3 ways to fix #226 :

  1. Always allow whitespaces (this PR).
  2. Don't allow on strict:
    2a. Change ElementExt to get Config. Breaking change, require version bump.
    2b. Wrappers for ElementExt methods and replace them on each usage.

@thejpster
Copy link

This PR only changes the CHANGELOG and nothing else?

@burrbull
Copy link
Member Author

Sorry

thejpster
thejpster approved these changes Sep 16, 2023
View reviewed changes
Copy link

@thejpster thejpster left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense to me

@burrbull burrbull added this pull request to the merge queue Sep 16, 2023
Merged via the queue into master with commit d516f06 Sep 16, 2023
7 checks passed
@burrbull burrbull deleted the trim-always branch September 16, 2023 11:12
@Emilgardis
Copy link
Member

I'm not sure I like this approach, but there shouldn't realistically be a scenario where a leading/trailing whitespace is meaningful so it's fine

@burrbull
Copy link
Member Author

I'm not sure I like this approach, but there shouldn't realistically be a scenario where a leading/trailing whitespace is meaningful so it's fine

I'm going to change this in future. I just don't want to do major release for such little change.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@thejpster thejpster thejpster approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@burrbull @thejpster @Emilgardis