Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Introduce the concept of Etable in core #186

Merged
merged 1 commit into from
Oct 29, 2023
Merged

Introduce the concept of Etable in core #186

merged 1 commit into from
Oct 29, 2023

Conversation

sorpaas
Copy link
Member

@sorpaas sorpaas commented Oct 29, 2023

Part of #183

Make an Etable that can be customized downstream to add additional handlers. The goal is so that runtime does not need to rely on trapping for common opcodes, which is unnecessary overhead. In the future, Runtime should be a really thin wrapper around Machine, and Machine will solely handle the interpreter loop. Only the gasometer will wrap heavily (but we'll utilize chunk gas metering).

This also makes AsyncRuntime easier.

@@ -1,4 +1,4 @@
[toolchain]
channel = "1.68.2"
channel = "nightly"
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Because of rust-lang/rust#116015
We don't need any nightly features.

To switch back to stable once that fix on Rust goes live.

@sorpaas sorpaas merged commit b73c33c into next Oct 29, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant