Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update AFLplusplus to 3.14c #189

Merged
merged 2 commits into from
Oct 8, 2021
Merged

Conversation

XAMPPRocky
Copy link
Contributor

@XAMPPRocky XAMPPRocky commented Sep 13, 2021

Hey, this has some useful changes, and I wanted to test if something was a bug in AFLplusplus or my code, so I figured I would upstream updating it.

@frewsxcv
Copy link
Member

It looks like this broke the Mac CI job. Any thoughts why that might have happened?

Proof that Mac CI is passing on master: #191

@XAMPPRocky
Copy link
Contributor Author

Let me check, I've been using this locally on my ARM Mac with no issues.

@smoelius
Copy link
Member

@XAMPPRocky Could you please try this? It fixed the problem for me in a fork of your branch:

echo 'diff --git a/.github/workflows/rust.yml b/.github/workflows/rust.yml
index c7c1af2..a5dea87 100644
--- a/.github/workflows/rust.yml
+++ b/.github/workflows/rust.yml
@@ -28,6 +28,8 @@ jobs:
         submodules: true
     - name: Build
       run: cargo build --verbose
+    - name: Run afl-system-config
+      run: sudo AFLPlusPlus/afl-system-config
     - name: Build examples (with AFL instrumentation)
       run: cargo run afl build --examples --verbose
     - name: Run tests (with AFL instrumentation)
' | git apply

@XAMPPRocky
Copy link
Contributor Author

@smoelius Thanks for fixing it. :)

@smoelius
Copy link
Member

NP. My request wasn't especially clear. :/ Glad it works!

@smoelius
Copy link
Member

smoelius commented Oct 2, 2021

@frewsxcv Are you satisfied with this change? Do you think it's okay to merge this?

@frewsxcv
Copy link
Member

frewsxcv commented Oct 2, 2021

If CI is passing and it's just a AFL++ bump, then sounds good to me!

@smoelius smoelius merged commit a9032be into rust-fuzz:master Oct 8, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants