Upgrade to clap 4 #263
Upgrade to clap 4 #263
Conversation
smoelius
force-pushed
the
clap-4
branch
5 times, most recently
from
36c9679
to
b262298
Compare
| @@ -17,7 +17,7 @@ tempfile = "3.3" | |||
| xdg = "2.4" | |||
|
|
|||
| [dependencies] | |||
| clap = { version = "3.2", features = ["cargo"] } | |||
| clap = { version = "4.0", features = ["cargo"] } | |||
There was a problem hiding this comment.
Tiny nit, but it might be worth considering bumping to the latest minor here (4.0.9), since they had a couple of bug fixes since 4.0.
There was a problem hiding this comment.
I have very mixed feelings about this. But the way I have been leaning lately is to not include patch versions in Cargo.toml files. Tracking patch versions tends to introduce a lot of noise, and I prefer changes to the Cargo.toml file to be "significant," e.g., addition/removal of a dependency.
There was a problem hiding this comment.
Yeah, this was based on a misunderstanding on my part. This is good to ignore.
| .subcommand_required(true) | ||
| .arg_required_else_help(true) | ||
| .allow_external_subcommands(true) | ||
| .external_subcommand_value_parser(value_parser!(OsString)) |
There was a problem hiding this comment.
Nit: I think this is the default value parser for external subcommands, so you can probably omit this line.
There was a problem hiding this comment.
My experiments support this.
However, I think I would prefer keep this line. If someone later reviews this change, I would like it to be clear that this line was not lost:
Line 112 in 3cba662
| .allow_hyphen_values(true) | ||
| .disable_help_subcommand(true) | ||
| .disable_help_flag(true) | ||
| .disable_version_flag(true) |
There was a problem hiding this comment.
Needs to be tested, but I believe subcommands now have their version flags disabled by default. So you might no longer need this line.
There was a problem hiding this comment.
I added several tests. Please tell me if you think there are still gaps, or if you do not like their approach(es).
|
Thanks a million, @woodruffw. |
No description provided.