Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix rust-analyzer incorrect-ident-case diagnostic #110

Merged
merged 2 commits into from
Jun 16, 2022

Conversation

CobaltCause
Copy link
Contributor

Using the derive macro in a project with rust-analyzer gives an error complaining that this generated code isn't in the SCREAMING_SNAKE_CASE form. This change makes this diagnostic message go away.

The exact output of rust-analyzer:

processing crate: playground, module: /home/charles/science/rust/playground/src/main.rs
Diagnostic { code: DiagnosticCode("incorrect-ident-case"), message: "Constant `RECURSIVE_COUNT_CustomThing` should have UPPER_SNAKE_CASE name, e.g. `RECURSIVE_COUNT_CUSTOM_THING`", range: 959..979, severity: WeakWarning, unused: false, experimental: false, fixes: None }

diagnostic scan complete

derive/Cargo.toml Outdated Show resolved Hide resolved
Using the derive macro in a project with rust-analyzer gives an error
complaining that this generated code isn't in the SCREAMING_SNAKE_CASE
form. This change makes this diagnostic message go away.
@Manishearth
Copy link
Member

needs a rustfmt, otherwise r+!

Copy link
Member

@fitzgen fitzgen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@fitzgen fitzgen merged commit 3ed2dc9 into rust-fuzz:master Jun 16, 2022
@fitzgen
Copy link
Member

fitzgen commented Jun 16, 2022

Published 1.1.2 with this fix.

@CobaltCause
Copy link
Contributor Author

Awesome, thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants