Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Annotate coverage, artifacts and corpus dirs with CACHEDIR.TAG #369

Closed
wants to merge 1 commit into from

Conversation

totikom
Copy link

@totikom totikom commented Mar 30, 2024

CACHEDIR.TAG is a widely adopted way to mark directories, that should be excluded from backups, archives and so on.
IMO, coverage, artifacts and corpus directories should not be backed up, so this change is beneficial for setups with automatic backups.

@totikom
Copy link
Author

totikom commented Mar 31, 2024

CI is failing because of this two tests:
image
But on my machine they are also failing on main branch. Can someone verify, if everything is ok with this tests on main?

@Shnatsel
Copy link
Member

Shnatsel commented Apr 1, 2024

Artifacts are especially valuable and have very low size (~kilobytes), so I see no reason to exclude them from backups.

I also tend to back up my corpora because they took days of compute to acquire, while only taking up single-digit numbers of megabytes even for large corpora (1000+ files).

If you are looking to reduce the size of backups, a much better way to approach it would be excluding the target directory, which is both reproducible without investing days of compute, and is multiple orders of magnitude larger.

Since this change is not clearly beneficial, and none of the maintainers can dogfood it and notice if something breaks, I'm going to go ahead and close this.

@Shnatsel Shnatsel closed this Apr 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants