Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix/ignore warnings within doctests #964

Merged

Conversation

Philippe-Cholet
Copy link
Member

#963 lead me to know about #![doc(test(attr(...)))].

Our doctests have some warnings that are ignored by default.
Here, I fix some, sometimes silently (comment out), and globally ignore deprecated and unstable_name_collisions.
Maybe I should allow(unused_variables) instead of many # let _ = ...;?

Copy link

codecov bot commented Jul 3, 2024

Codecov Report

Attention: Patch coverage is 91.30435% with 2 lines in your changes missing coverage. Please review.

Project coverage is 94.51%. Comparing base (6814180) to head (9238e2a).
Report is 108 commits behind head on master.

Files Patch % Lines
src/lib.rs 87.50% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #964      +/-   ##
==========================================
+ Coverage   94.38%   94.51%   +0.12%     
==========================================
  Files          48       49       +1     
  Lines        6665     7072     +407     
==========================================
+ Hits         6291     6684     +393     
- Misses        374      388      +14     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Philippe-Cholet Philippe-Cholet added this pull request to the merge queue Jul 3, 2024
@Philippe-Cholet Philippe-Cholet added this to the next milestone Jul 3, 2024
Merged via the queue into rust-itertools:master with commit 3067893 Jul 3, 2024
13 of 14 checks passed
@Philippe-Cholet Philippe-Cholet deleted the doctest-warnings branch July 3, 2024 08:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants