Skip to content

Commit

Permalink
Auto merge of rust-lang#126641 - ferrocene:hoverbear/enable-riscv64gc…
Browse files Browse the repository at this point in the history
…-testing, r=<try>

Enable `riscv64gc` testing

Together with [email protected], we've been starting to explore improving the state of the `riscv64gc-unknown-linux-gnu` target. Additionally, I'm looking to add support for this platform in [Ferrocene](https://github.com/ferrocene/ferrocene) ([Related PR](ferrocene/ferrocene#618)).

Recently several PRs have landed improving the state of this target:

* rust-lang#125220
* rust-lang#125669
* rust-lang#126355
* rust-lang#126279
* rust-lang#126707
* rust-lang#126916
* rust-lang#126917
* rust-lang#127280

The result has been that `riscv64gc-unknown-linux-gnu` now *should* pass the same CI tests that `x86_64-unknown-linux-gnu` and `aarch64-unknown-linux-gnu` do.

## Testing

> [!NOTE]
> While `riscv64gc-unknown-linux-gnu` is a [**Tier 2 with Host Tools** platform](https://doc.rust-lang.org/beta/rustc/platform-support.html) (meaning all tests may not necessarily pass) we do need to see all of the tests passing here. Indeed, the point of this PR is to get `riscv64gc-unknown-linux-gnu` into automated testing so the tests can *remain* working.

You can test out the job locally:

```sh
DEPLOY=1 ./src/ci/docker/run.sh riscv64gc-gnu
```

`DEPLOY=1` helps reproduce the CI's environment and also avoids the chance of a `llvm-c/BitReader.h` error (detailed in rust-lang#85424 and rust-lang#56650).

try-job: riscv64gc-gnu
  • Loading branch information
bors committed Jul 4, 2024
2 parents 9f877c9 + 7e69568 commit 44b82ad
Show file tree
Hide file tree
Showing 3 changed files with 3 additions and 0 deletions.
3 changes: 3 additions & 0 deletions src/ci/github-actions/jobs.yml
Original file line number Diff line number Diff line change
Expand Up @@ -205,6 +205,9 @@ auto:
- image: mingw-check
<<: *job-linux-4c

- image: riscv64gc-gnu
<<: *job-linux-4c

- image: test-various
<<: *job-linux-4c

Expand Down

0 comments on commit 44b82ad

Please sign in to comment.