Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cleanup and updates #61

Merged
merged 6 commits into from
Nov 8, 2023
Merged

Conversation

Muscraft
Copy link
Member

@Muscraft Muscraft commented Nov 8, 2023

This PR:

  • Removes unneeded badges from Cargo.toml and README.md
  • Moves to Edition 2021
  • Sets MSRV to 1.70.0 to match CI
  • Sorted the dependencies alphabetically
  • Fully specified dependency versions
  • Updated criterion to the newest version

Note: Updating edition and rust-version is "Possibly" a semver-breaking change. It is recommended that this is treated as a minor change, and since this is a pre-1.0.0 crate, we should bump the patch version when this is released, that is 0.9.3.

Note: I could not update toml to the newest version as it stopped supporting borrowing while deserializing, which is needed for the fixture tests.

@Muscraft Muscraft merged commit 7fe7ce9 into rust-lang:master Nov 8, 2023
12 checks passed
@Muscraft Muscraft deleted the cleanup-and-updates branch November 8, 2023 23:09
@zbraniecki
Copy link
Contributor

Note: I could not update toml to the newest version as it stopped supporting borrowing while deserializing, which is needed for the fixture tests.

I hit this too when I was planning to update. From reading the docs they are considering reverting that limitation. But since it's used in tests, we could do allocations if needed. For now I kept us stuck on 0.5

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants