Fall back to dladdr on Unix in more places
#196
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Almost all platforms should still have some degree of symbolication without debug symbols being present (aka the dynamic symbol table and such), so add a test asserting that symbols do indeed come out in these scenarios. This test will likely need to be blacklisted for platforms over time, but that's ok.
alexcrichton
force-pushed
the
work-without-debuginfo
branch
from
f76b004
to
2271fb8
Compare
Currently CoreSymbolication will fall back to `dladdr` but this also applies the same logic to the `libbacktrace` symbolication strategy since libbacktrace (especially on OSX) can't always get symbol name information. Instead these platforms will all fall back to `dladdr` if no symbol information is learned from libbacktrace. This involved some refactoring internally since all invocations calling the `dladdr` function are now shared instead of having three separate ones throughout.
alexcrichton
force-pushed
the
work-without-debuginfo
branch
from
2271fb8
to
861faf1
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently CoreSymbolication will fall back to
dladdrbut this alsoapplies the same logic to the
libbacktracesymbolication strategysince libbacktrace (especially on OSX) can't always get symbol name
information. Instead these platforms will all fall back to
dladdrifno symbol information is learned from libbacktrace.
This involved some refactoring internally since all invocations calling
the
dladdrfunction are now shared instead of having three separateones throughout.