Remove libbacktrace implementation #423
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit removes the `backtrace-sys` crate and the libbacktrace implementation of this crate. For quite some time now the `gimli-symbolize` feture has been on-by-default. While `libbacktrace` has been an option all relevant features should have been implemented in `gimli-symbolize` by now. The libbacktrace implementation has always been approached with wariness where it may segfault or cause worse behavior when fed bad debug information. Debug information is possible to change at runtime, so libbacktrace has always been a risk for Rust binaries. Additionally libbacktrace development was very quite for a very long time and our patches upstream were generally met with silence. Development seems to have picked back up upstream but with this crate now switched to gimli I'm not too personally motivated to check to see if all our fixes have landed. In general, though, libbacktrace upstream always worked best with Linux and other platforms were more "best-effort". Additionally gimli now has more features for supporting compressed and split-debuginfo as well. This commit comes about to reduce the maintenance burden on this crate. Recent changes in rust-lang/rust have actually broken libbacktrace testing. This appears fixed with sync'ing to the upstream repository of libbacktrace, but it seems like now's the right time to go ahead and remove the crate.
alexcrichton
force-pushed
the
rm-libbacktrace
branch
from
6222f70
to
e42c4e9
Compare
3 tasks
matthiaskrgr
pushed a commit
to matthiaskrgr/rust
that referenced
this pull request
Oct 2, 2022
Use of libbacktrace was removed in 06d565c where we switched to using the gimili library instead. Note: the backtrace submodule located at library/backtrace points to backtrace-rs which removed support for using libbacktrace in rust-lang/backtrace-rs#423.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit removes the
backtrace-syscrate and the libbacktraceimplementation of this crate. For quite some time now the
gimli-symbolizefeture has been on-by-default. Whilelibbacktracehas been an option all relevant features should have been implemented in
gimli-symbolizeby now.The libbacktrace implementation has always been approached with wariness
where it may segfault or cause worse behavior when fed bad debug
information. Debug information is possible to change at runtime, so
libbacktrace has always been a risk for Rust binaries. Additionally
libbacktrace development was very quiet for a very long time and our
patches upstream were generally met with silence. Development seems to
have picked back up upstream but with this crate now switched to gimli
I'm not too personally motivated to check to see if all our fixes have
landed. In general, though, libbacktrace upstream always worked best
with Linux and other platforms were more "best-effort". Additionally
gimli now has more features for supporting compressed and
split-debuginfo as well.
This commit comes about to reduce the maintenance burden on this crate.
Recent changes in rust-lang/rust have actually broken libbacktrace
testing. This appears fixed with sync'ing to the upstream repository of
libbacktrace, but it seems like now's the right time to go ahead and
remove the crate.
Closes #234
Closes #290
Closes #409