Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update diagnostics migration blog post to use new flat slugs #1040

Merged
merged 1 commit into from
Oct 27, 2022

Conversation

Noratrieb
Copy link
Member

In rust-lang/rust#103345, I've migrated the diagnostics to use the slugs in a flat module instead of one module for each crate.

This changes to blog post to use the new syntax.

@davidtwco

@est31
Copy link
Member

est31 commented Oct 21, 2022

@Nilstrieb you probably also want to change the dev guide like I did in rust-lang/rustc-dev-guide#1426

@Noratrieb
Copy link
Member Author

Working on it right now 👍

Copy link
Member

@davidtwco davidtwco left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, don't think I have permissions for this repo though.

@Noratrieb
Copy link
Member Author

@rylev

@rylev rylev merged commit 5885684 into rust-lang:master Oct 27, 2022
@Noratrieb Noratrieb deleted the patch-1 branch October 27, 2022 15:40
@Noratrieb
Copy link
Member Author

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants