Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Apply impl lifetime elision rules #1857

Closed
wants to merge 1 commit into from

Conversation

theJian
Copy link

@theJian theJian commented Mar 12, 2019

rust 2018 edition adds an additional elision rule for impl header.

related: #1273

@theJian
Copy link
Author

theJian commented Mar 12, 2019

This chapter doesn't cover the '_ shorthand. What do you think about adding some details on it?

@carols10cents carols10cents added this to the ch10 milestone Apr 12, 2019
@carols10cents
Copy link
Member

Thanks! Unfortunately, the anonymous lifetime definitely needs to be introduced before we use it here. Additionally, the text after the first place you've changed needs to be updated, and the whole section should be checked to make sure it still makes sense.

So I'm going to close this in favor of a larger effort to incorporate the anonymous lifetime, which is tracked by #1273. Thanks though!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants