Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update println! calls to dbg! where appropriate #2842

Closed
wants to merge 5 commits into from

Conversation

mikemorris
Copy link

@mikemorris mikemorris commented Aug 28, 2021

Started working on this locally on an older checkout and then discovered it was mostly added in 5813399 so rebased to resolve the conflict with the newer explanation, but can still help finish updating the later references to close #1658

Initially searched for matches on {: to target pretty-prints, then against plain println!("{}", calls that could be included too. Some remaining cases may exist but currently print additional context or could be a little more ambiguous. Ignored usage prior to introducing dbg! in chapter 5.

Checked and decided not to update:

@carols10cents carols10cents added this to the ch8 milestone Sep 16, 2021
@carols10cents carols10cents modified the milestones: ch8, ch9 Oct 15, 2021
@nyurik
Copy link
Contributor

nyurik commented Feb 6, 2022

I did some println changes in #3048, and some might conflict. Not sure which should be used where... I guess anything that doesn't print additional information should use dbg!()...?

@carols10cents carols10cents modified the milestones: ch9, ch12, ch13 May 31, 2022
carols10cents added a commit that referenced this pull request Jun 4, 2022
- Change the variable name from filename to file_path. Fixes #3142.
- Use the new println capture. Connects to #3048.
- Use dbg! when appropriate. Connects to #2842.
- Improve the expect message to read better. Connects to #2918.
@carols10cents carols10cents modified the milestones: ch13, ch16 Jun 4, 2022
carols10cents added a commit that referenced this pull request Jun 4, 2022
- Change the variable name from filename to file_path. Fixes #3142.
- Use the new println capture. Connects to #3048.
- Use dbg! when appropriate. Connects to #2842.
- Improve the expect message to read better. Connects to #2918.
@carols10cents carols10cents modified the milestones: ch16, ch18 Jun 6, 2022
@mikemorris mikemorris closed this Jun 6, 2022
@mikemorris mikemorris deleted the dbg-macro branch June 6, 2022 22:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Documentation about the dbg! macro
3 participants