Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Work towards getting tidy clean #536

Merged
merged 4 commits into from
Mar 13, 2017
Merged

Work towards getting tidy clean #536

merged 4 commits into from
Mar 13, 2017

Conversation

steveklabnik
Copy link
Member

For rust-lang/rust#40332 we need to get tidy clean. See https://travis-ci.org/rust-lang/rust/jobs/208767193#L500 for the failure.

This takes care of almost all of it. The last bit is some regexes that we have that are over 100 lines.

@alexcrichton what do you do in situations like https://github.com/rust-lang/book/blob/master/second-edition/tools/src/bin/link2print.rs#L42 ?

@steveklabnik
Copy link
Member Author

The current set of failures:

\second-edition\tools\src\bin\lfp.rs:246: line longer than 100 chars
\second-edition\tools\src\bin\lfp.rs:253: line longer than 100 chars
\second-edition\tools\src\bin\lfp.rs:254: line longer than 100 chars
\second-edition\tools\src\bin\link2print.rs:52: line longer than 100 chars
\second-edition\tools\src\bin\link2print.rs:75: line longer than 100 chars
\second-edition\tools\src\bin\link2print.rs:77: line longer than 100 chars
\second-edition\tools\src\bin\link2print.rs:81: line longer than 100 chars
\second-edition\tools\src\bin\link2print.rs:344: line longer than 100 chars
\second-edition\tools\src\bin\link2print.rs:359: line longer than 100 chars

@steveklabnik
Copy link
Member Author

Alex says it's fine to just ignore these files with tidy.

@steveklabnik steveklabnik merged commit be517a8 into master Mar 13, 2017
@steveklabnik steveklabnik deleted the tidy-clean branch March 13, 2017 18:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant