Do not unconditionally set the target. #323
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This removes the
CARGO_BUILD_TARGET
environment variable which causes cargo to unconditionally work in "cross compile mode". This is different from a normalcargo
invocation without the--target
flag, in which case it runs in "host mode", where cargo and other tools have distinctly different behavior. This can be surprising when you get one behavior withcargo build
and a different one withcargo bisect-rustc
.This was added in #159 to address some issue with using
cross-rs
withcargo bisect-rustc
. I'm not sure why, as I would think the recommended behavior when using cross is to set the--target
flag. The given PR didn't really explain the situation.Closes #284