Skip to content

Commit

Permalink
Auto merge of #12528 - epage:downgrade, r=Muscraft
Browse files Browse the repository at this point in the history
chore: Downgrade serde below the binary blob

As of serde 1.0.172, `serde_derive` ships a binary blog for Linux x64 for faster build times.  This blob is not yet reproducible to ensure that the safety of it.  See serde-rs/serde#2538.  See also https://diff.rs/serde_derive/1.0.171/1.0.172/Cargo.toml

This is not a judgement on serde or on dtolnay but just a precaution to buy us more time as the community works through this since the beta cut is coming up.  rust-1.72 branch is unaffected.
  • Loading branch information
bors committed Aug 19, 2023
2 parents 7babad7 + 4793669 commit 80eca0e
Show file tree
Hide file tree
Showing 2 changed files with 5 additions and 5 deletions.
8 changes: 4 additions & 4 deletions Cargo.lock

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion Cargo.toml
Original file line number Diff line number Diff line change
Expand Up @@ -75,7 +75,7 @@ rustfix = "0.6.1"
same-file = "1.0.6"
security-framework = "2.9.2"
semver = { version = "1.0.18", features = ["serde"] }
serde = "1.0.180"
serde = "1.0.171"
serde-value = "0.7.0"
serde_ignored = "0.1.9"
serde_json = "1.0.104"
Expand Down

3 comments on commit 80eca0e

@simonsan
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@epage Question, shouldn't this be: serde = "=1.0.171"?

@epage
Copy link
Contributor

@epage epage commented on 80eca0e Aug 19, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@simonsan
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That is what the lockfile is for, see https://doc.rust-lang.org/nightly/cargo/reference/specifying-dependencies.html#multiple-requirements

Ahh, I didn't check that. I'm so used to Cargo just working it's way and trusting it kind of that I don't look at the lockfile changes often enough. As in this case. Thanks!

Please sign in to comment.