Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Style of help text headings in cargo-add and cargo-rm should be consistent with clap v4 #11238

Closed
weihanglo opened this issue Oct 14, 2022 · 0 comments · Fixed by #11239
Closed

Style of help text headings in cargo-add and cargo-rm should be consistent with clap v4 #11238

weihanglo opened this issue Oct 14, 2022 · 0 comments · Fixed by #11239
Assignees
@epage
Labels
A-cli-help Area: built-in command-line help C-bug Category: bug E-easy Experience: Easy

Comments

@weihanglo
Copy link
Member

weihanglo commented Oct 14, 2022 •
edited
Loading

Problem

  • Headings are now Title case

Ref: https://github.com/clap-rs/clap/blob/bd5a6eab3bb4c8e3bd9f75be83821f316dde8ac8/CHANGELOG.md?plain=1#L178

Steps

$ cargo rm --help
Remove dependencies from a Cargo.toml manifest file

Usage: 
    …
    …

SECTION: <---- Should be "Title case"
    …
$ cargo add --help
Add dependencies to a Cargo.toml manifest file

Usage:
  …
  …

SOURCE: <---- Should be "Title case"
  …

SECTION: <---- Should be "Title case"
  …

Possible Solution(s)

Search next_help_heading and update arguments accordingly to Title case.

Notes

No response

Version

commit b332991a57c9d055f1864de1eed93e2178d49440
@weihanglo weihanglo added C-bug Category: bug E-easy Experience: Easy A-cli-help Area: built-in command-line help labels Oct 14, 2022
@epage epage mentioned this issue Oct 14, 2022
Merged
@epage epage self-assigned this Oct 14, 2022
bors added a commit that referenced this issue Oct 14, 2022
@bors
Auto merge of #11239 - epage:add, r=weihanglo
99ff79e 
fix: Update help headings to  match clap

This was missed when upgrading to clap v4

Fixes #11238
@bors bors closed this as completed in f46da37 Oct 14, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@epage epage

Labels
A-cli-help Area: built-in command-line help C-bug Category: bug E-easy Experience: Easy
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: Update help headings to match clap epage/cargo
2 participants
@epage @weihanglo