New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Pass --color option down to rustc #2740

Closed

birkenfeld opened this issue May 25, 2016 · 1 comment · Fixed by #2779

Contributor

birkenfeld commented May 25, 2016 •

edited

Loading

For subprocesses we know support --color=auto/always/never options like rustc, the option should be passed to them as well.

The text was updated successfully, but these errors were encountered:

matklad mentioned this issue

Propagate --color option to rustc #2779

Merged

bors added a commit that referenced this issue


          Auto merge of #2779 - matklad:propagete-color-config, r=alexcrichton

13861b7

Propagate --color option to rustc

closes #2740

Will try to add a test for this soon (and fix failing tests if any, compiling/running tests locally is slow :( ).

I am not sure what is the right place to add `--color` option to the command line. I use [`build_base_args`]. [`process`] also looks like a good candidate, because it is more general, but if we look at the [`CommandType`] we see that only `rustc` command supports `--color`.

[`build_base_args`]: https://github.com/matklad/cargo/blob/1f7504397ce7c40ff708e2d31da164822e88ed37/src/cargo/ops/cargo_rustc/mod.rs#L449
[`process`]: https://github.com/matklad/cargo/blob/1f7504397ce7c40ff708e2d31da164822e88ed37/src/cargo/ops/cargo_rustc/mod.rs#L608
[`CommandType`]: https://github.com/matklad/cargo/blob/1f7504397ce7c40ff708e2d31da164822e88ed37/src/cargo/ops/cargo_rustc/engine.rs#L102

bors closed this as completed in #2779

Contributor Author

birkenfeld commented Jun 10, 2016

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment