Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support non-#[test] tests/non-#[bench] benchmarks #431

Closed
huonw opened this issue Aug 25, 2014 · 1 comment · Fixed by #435
Closed

Support non-#[test] tests/non-#[bench] benchmarks #431

huonw opened this issue Aug 25, 2014 · 1 comment · Fixed by #435

Comments

@huonw
Copy link
Member

huonw commented Aug 25, 2014

Some libraries construct tests dynamically (e.g. in that case, it is reading an external set of testcases), having tests that aren't compiled with --test would allow for this, e.g.

[[test]]
name = "foo"
test_harness = false

(And similarly for benchmarks, example.)
@alexcrichton
Copy link
Member

Sounds like a good idea!

This was referenced Aug 25, 2014
Closed
Closed
@alexcrichton alexcrichton mentioned this issue Aug 25, 2014
Merged
alexcrichton added a commit to alexcrichton/cargo that referenced this issue Aug 27, 2014
@alexcrichton
Add a harness manifest option
3139293 
This option is used to disable the --test flag to rustc for a test or benchmark
target in order to signal that the binary already knows how to run the testing
infrastructure.

The test/benchmark is still compiled and run as usual, and the exit code is
expected to reflect the result of the test/benchmark.

Closes rust-lang#431
bors added a commit that referenced this issue Aug 27, 2014
@bors
auto merge of #435 : alexcrichton/cargo/issue-431, r=brson
26688f4 
This option is used to disable the --test flag to rustc for a test or benchmark
target in order to signal that the binary already knows how to run the testing
infrastructure.

The test/benchmark is still compiled and run as usual, and the exit code is
expected to reflect the result of the test/benchmark.

Closes #431
@bors bors closed this as completed in #435 Aug 27, 2014
alexcrichton added a commit to alexcrichton/cargo that referenced this issue Sep 2, 2014
@alexcrichton
Add a harness manifest option
a658968 
This option is used to disable the --test flag to rustc for a test or benchmark
target in order to signal that the binary already knows how to run the testing
infrastructure.

The test/benchmark is still compiled and run as usual, and the exit code is
expected to reflect the result of the test/benchmark.

Closes rust-lang#431
bors added a commit to alexcrichton/cargo that referenced this issue Sep 2, 2014
@bors
auto merge of rust-lang#435 : alexcrichton/cargo/issue-431, r=brson
caf8345 
This option is used to disable the --test flag to rustc for a test or benchmark
target in order to signal that the binary already knows how to run the testing
infrastructure.

The test/benchmark is still compiled and run as usual, and the exit code is
expected to reflect the result of the test/benchmark.

Closes rust-lang#431
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add a harness manifest option alexcrichton/cargo
2 participants
@alexcrichton @huonw