Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

cargo build --all-targets doesn't work with binary crates and workspaces #4615

Closed
BenjaminGill-Metaswitch opened this issue Oct 13, 2017 · 0 comments · Fixed by #4685
Closed

cargo build --all-targets doesn't work with binary crates and workspaces #4615

BenjaminGill-Metaswitch opened this issue Oct 13, 2017 · 0 comments · Fixed by #4685
Labels
A-workspaces Area: workspaces C-bug Category: bug Command-build

Comments

@BenjaminGill-Metaswitch
Copy link

I've got a large workspace containing a mixture of library and binary crates. cargo build --all-targets seems to work fine when run against the library crates (modulo #2495 (comment)).

However, running it against either a crate with no library targets or the workspace root (it's a virtual manifest) gives:

$ cargo build --all-targets
error: no library targets found

I wonder if this is a problem with handling of crates with no library targets?
@carols10cents carols10cents added A-workspaces Area: workspaces Command-build C-bug Category: bug labels Oct 16, 2017
ehuss added a commit to ehuss/cargo that referenced this issue Oct 30, 2017
@ehuss
Fix --all-targets in a crate without a lib.
b9497ab 
Fixes rust-lang#4615.
@ehuss ehuss mentioned this issue Oct 30, 2017
Merged
bors added a commit that referenced this issue Oct 30, 2017
@bors
Auto merge of #4685 - ehuss:all-targets-no-lib, r=alexcrichton
f4aeb00 
Fix --all-targets in a crate without a lib.

Fixes #4615.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
A-workspaces Area: workspaces C-bug Category: bug Command-build
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix --all-targets in a crate without a lib. ehuss/cargo
2 participants
@carols10cents @BenjaminGill-Metaswitch